Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add action buttons to bottom of card #31

Merged
merged 2 commits into from
Jun 26, 2022

Conversation

wunter8
Copy link
Contributor

@wunter8 wunter8 commented May 30, 2022

fixes binwiederhier/ntfy#236

I know you're busy with iOS stuff, but here's this when you have a chance!

I wasn't sure if you also want the file/attachment related buttons at the bottom of the card. And I decided to create 3 hardcoded placeholder buttons (since only 3 actions are allowed), but if you want the file/attachment buttons down there, too, it might be best to switch these to dynamic buttons created in the DetailAdapter instead of defined in the .xml

ntfy-android-action-buttons

@binwiederhier
Copy link
Owner

I love it. Thank you. I'll try+merge it when I do Android work again!!

@binwiederhier
Copy link
Owner

Just letting you know I haven't forgotten about this. I won't do Android work for a while, so this may sit here for a week or two.

@wunter8
Copy link
Contributor Author

wunter8 commented Jun 4, 2022

No worries! Take your time. I know you're making really good progress with iOS stuff right now.

I've been thinking about making the buttons dynamic so it's easy to use for links, attachments, and user actions. We'll see if I get around to that in the next week or two.

@wunter8
Copy link
Contributor Author

wunter8 commented Jun 10, 2022

I got the dynamic buttons working, so they can be used for everything in the 3 dot popup menu. Want me to work on that?

It looks like the most the web app shows is "copy url", "open attachment", "copy link", "open link" and then up to 3 user actions. The popup Android menu has some extra items like "download file", "delete file", "save file", and "cancel download". Should all of those be moved to MaterialButtons at the bottom of the card or leave some (or all) of them in the popup menu?

@binwiederhier
Copy link
Owner

Thank you!

I'd need to look at it to see if it makes sense. I think it's visually nicer to have some of the actions in a menu. But again, I'd need to try it. Alternatively, you could post a screenshot, but I still think I'd want to try it.

If you've got some time to spare, there are probably lots of other Android tickets :) Especially since I'm doing iOS work still.... :)

@wunter8
Copy link
Contributor Author

wunter8 commented Jun 11, 2022

I've been looking at the other Android tickets, and I feel like a lot of them require some sort of design discussion, either about UI/UX or implementation.

I fixed binwiederheir/ntfy#235 already
I thought about binwiederhier/ntfy#313 but would want to talk about DB design and stuff
I haven't been able to reproduce binwiederhier/ntfy#261
I started on binwiederhier/ntfy#260 but would want to discuss design and implementation
I might work on binwiederhier/ntfy#229, but it would involve changing messages to/from the server, so I'd want to discuss that stuff, too

I'd love to help, but I don't want to put extra work on your plate (e.g., making you think about and solve all these design/implementation details right now). If you have an idea in mind for any of these already, though, I can get started on the code

@binwiederhier binwiederhier merged commit c480c14 into binwiederhier:main Jun 26, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Move action buttons in detail view from menu to bottom of card (like in web UI)
2 participants