Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Security issue with attachment peaking #93

Closed
binwiederhier opened this issue Jan 14, 2022 · 0 comments
Closed

Security issue with attachment peaking #93

binwiederhier opened this issue Jan 14, 2022 · 0 comments
Labels
🪲 bug Something isn't working 🔒 security Security related ticket server Relates to the main binary (server or client)

Comments

@binwiederhier
Copy link
Owner

binwiederhier commented Jan 14, 2022 •
edited
Loading

With the attachment peaking feature for external URLs it was possible to probe localhost for open ports. I was not comfortable with leaving this in and it's tricky/impossible to isolate processes from the internal network, so I removed the feature.

The Android client will do the probing now.
@binwiederhier binwiederhier added 🪲 bug Something isn't working server Relates to the main binary (server or client) labels Jan 14, 2022
binwiederhier pushed a commit that referenced this issue Jan 14, 2022
Remove peaking, addresses #93
e507796
@binwiederhier binwiederhier changed the title Issue with attachment peaking Security issue with attachment peaking Jan 14, 2022
@binwiederhier binwiederhier added the 🔒 security Security related ticket label Jan 14, 2022
@binwiederhier binwiederhier mentioned this issue Feb 15, 2022
Closed
@binwiederhier binwiederhier mentioned this issue Jun 12, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
🪲 bug Something isn't working 🔒 security Security related ticket server Relates to the main binary (server or client)
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@binwiederhier