-
-
Notifications
You must be signed in to change notification settings - Fork 751
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
PWA: Fix reload, Firefox mp3 load, reduce mobile padding #795
PWA: Fix reload, Firefox mp3 load, reduce mobile padding #795
Conversation
Codecov ReportPatch and project coverage have no change.
❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more. Additional details and impacted files@@ Coverage Diff @@
## main #795 +/- ##
=======================================
Coverage 65.85% 65.85%
=======================================
Files 53 53
Lines 7646 7646
=======================================
Hits 5035 5035
Misses 1775 1775
Partials 836 836 ☔ View full report in Codecov by Sentry. |
The "hotfix" for the .mp3 stuff only required the .mp3 change, right? This PR includes a bunch of things. Hotfixes should only ever include the minimal possible change to make what's released already work. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good stuff.
Normally I'd do the changes myself and roll with it, but I'm too tired. Turns out real work is exhausting.
Done!
especially the first weeks!
Indeed - I added the sw stuff because the sw was missing the client claim, and this will roll out the fixes faster than without |
No description provided.