Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP: set packages to noarch: generic where linter has indicated they should be #17780

Conversation

pinin4fjords
Copy link
Contributor

As part of collaboration fest, this PR attempts to add noarch: generic to build sections where a lint over all recipes suggested that line should be present.

@dpryan79
Copy link
Contributor

dpryan79 commented Oct 1, 2019

@pinin4fjords Can you grant us access to modify this? There should be a tick-box to allow that somewhere to the right of this comment.

@dpryan79
Copy link
Contributor

dpryan79 commented Oct 1, 2019

@bgruening We'll have to think about how best to do this. We need to bump build numbers, but I expect half of these haven't been changed to noarch (or otherwise fixed) because they're just not used/updated.

@pinin4fjords
Copy link
Contributor Author

'Allow edits from maintainers' is checked @dpryan79 - you really can't edit?

@dpryan79
Copy link
Contributor

dpryan79 commented Oct 1, 2019

@pinin4fjords Not from the command line. I presumably can via the web interface, but if I'm going to clean up the recipes more I might as well do it all the way. Can you push it instead to a branch instead of your fork?

@biocondabot
Copy link
Contributor

biocondabot bot commented Oct 1, 2019

No artifacts found on recent CircleCI builds.

@dpryan79
Copy link
Contributor

dpryan79 commented Oct 1, 2019

I've made a new branch on this repo with your changes and some of my own.

@dpryan79
Copy link
Contributor

dpryan79 commented Oct 1, 2019

Xref: #17783

@pinin4fjords
Copy link
Contributor Author

Okay @dpryan79 - I also pushed the branch to upstream

@dpryan79 dpryan79 mentioned this pull request Oct 2, 2019
5 tasks
@dpryan79
Copy link
Contributor

dpryan79 commented Oct 4, 2019

Closed by #17783, thanks!

@dpryan79 dpryan79 closed this Oct 4, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants