Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update - another attempt at SPAdes 3.15.5 osx build #48097

Merged
merged 8 commits into from
May 28, 2024

Conversation

chrisjackson-pellicle
Copy link
Contributor

Yet another attempt to get osx builds working for SPAdes 3.15.5 (see here)


Please read the guidelines for Bioconda recipes before opening a pull request (PR).

General instructions

  • If this PR adds or updates a recipe, use "Add" or "Update" appropriately as the first word in its title.
  • New recipes not directly relevant to the biological sciences need to be submitted to the conda-forge channel instead of Bioconda.
  • PRs require reviews prior to being merged. Once your PR is passing tests and ready to be merged, please issue the @BiocondaBot please add label command.
  • Please post questions on Gitter or ping @bioconda/core in a comment.

Instructions for avoiding API, ABI, and CLI breakage issues

Conda is able to record and lock (a.k.a. pin) dependency versions used at build time of other recipes.
This way, one can avoid that expectations of a downstream recipe with regards to API, ABI, or CLI are violated by later changes in the recipe.
If not already present in the meta.yaml, make sure to specify run_exports (see here for the rationale and comprehensive explanation).
Add a run_exports section like this:

build:
  run_exports:
    - ...

with ... being one of:

Case run_exports statement
semantic versioning {{ pin_subpackage("myrecipe", max_pin="x") }}
semantic versioning (0.x.x) {{ pin_subpackage("myrecipe", max_pin="x.x") }}
known breakage in minor versions {{ pin_subpackage("myrecipe", max_pin="x.x") }} (in such a case, please add a note that shortly mentions your evidence for that)
known breakage in patch versions {{ pin_subpackage("myrecipe", max_pin="x.x.x") }} (in such a case, please add a note that shortly mentions your evidence for that)
calendar versioning {{ pin_subpackage("myrecipe", max_pin=None) }}

while replacing "myrecipe" with either name if a name|lower variable is defined in your recipe or with the lowercase name of the package in quotes.

Bot commands for PR management

Please use the following BiocondaBot commands:

Everyone has access to the following BiocondaBot commands, which can be given in a comment:

@BiocondaBot please update Merge the master branch into a PR.
@BiocondaBot please add label Add the please review & merge label.
@BiocondaBot please fetch artifacts Post links to CI-built packages/containers.
You can use this to test packages locally.

Note that the @BiocondaBot please merge command is now depreciated. Please just squash and merge instead.

Also, the bot watches for comments from non-members that include @bioconda/<team> and will automatically re-post them to notify the addressed <team>.

@chrisjackson-pellicle
Copy link
Contributor Author

Related: #47860 (comment)

@chrisjackson-pellicle
Copy link
Contributor Author

chrisjackson-pellicle commented May 27, 2024

test_osx fails. The raw log has the error:

CMake Error at /opt/mambaforge/envs/bioconda/conda-bld/spades_1716806771783/_build_env/share/cmake-3.29/Modules/CMakeTestCCompiler.cmake:67 (message):
The C compiler "/opt/mambaforge/envs/bioconda/conda-bld/spades_1716806771783/_build_env/bin/x86_64-apple-darwin13.4.0-clang" is not able to compile a simple test program. It fails with the following output:

...
...

ld: unsupported tapi file type '!tapi-tbd' in YAML file '/Applications/Xcode_14.2.app/Contents/Developer/Platforms/MacOSX.platform/Developer/SDKs/MacOSX.sdk/usr/lib/libSystem.tbd' for architecture x86_64
clang-9: error: linker command failed with exit code 1 (use -v to see invocation)
make[1]: *** [CMakeFiles/cmTC_1e4f7.dir/build.make:100: cmTC_1e4f7] Error 1

This is beyond my knowledge level, but:

  1. Attempts to build the OSX package on my local Mac using conda build (i.e. not using bioconda-utils build) resulted in a similar "unsupported tapi file type '!tapi-tbd' in YAML file" error.

  2. Following the advice here and here, I downloaded MacOSX10.10.sdk and set the CONDA_BUILD_SYSROOT environment variable to point towards it. Running conda build no longer resulted in the "unsupported tapi file type '!tapi-tbd' in YAML file" error; the build continued past this previous error point, although it still failed downstream with errors such as error: no member named 'ldiv' in the global namespace. EDIT - I see that stub libraries (YAML files with extension *.tbd) didn't exist in Apple SDKs until version macOS 10.11 SDK (see here) - hence the lack of "!tapi-tbd" error when using MacOSX10.10.sdk.

From the raw log, it looks like the Bioconda OSX build is using Xcode 14.2 with MacOSX13.1.sdk i.e.CONDA_BUILD_SYSROOT=/Applications/Xcode_14.2.app/Contents/Developer/Platforms/MacOSX.platform/Developer/SDKs/MacOSX.sdk and -isysroot /Applications/Xcode_14.2.app/Contents/Developer/Platforms/MacOSX.platform/Developer/SDKs/MacOSX13.1.sdk. Although is looks like calls to -isysroot are ignored when CONDA_BUILD_SYSROOT is set.

I'm wondering if the Xcode / SDK version is the issue, or whether one of the issues outlined in the accepted answer here could be relevant. @bgruening, any thoughts?

@chrisjackson-pellicle
Copy link
Contributor Author

...and, after all that, it seems to build fine after removing the conda_build_config.yaml with version constraints on the compilers.

@chrisjackson-pellicle
Copy link
Contributor Author

@BiocondaBot please add label

@martin-g martin-g merged commit e3b7203 into bioconda:master May 28, 2024
6 checks passed
mnshgl0110 pushed a commit to mnshgl0110/bioconda-recipes that referenced this pull request May 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
please review & merge set to ask for merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants