Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace tip/internal node metadata structures in empress.js with arrays? #355

Closed
fedarko opened this issue Aug 27, 2020 · 1 comment
Closed

Comments

@fedarko
Copy link
Collaborator

fedarko commented Aug 27, 2020

Since the keys in these Objects are the postorder position of a node, it should be feasible to just store these as Arrays (where the i-th entry holds data for the i-th node in the postorder position), analogous to @kwcantrell's comment at #339 (comment).

@fedarko fedarko changed the title Replace tip/internal node metadata structures in empress.js with arrays Replace tip/internal node metadata structures in empress.js with arrays? Aug 27, 2020
fedarko added a commit to fedarko/empress that referenced this issue Aug 30, 2020
work on biocore#355, which i think makes sense to bundle with biocore#337
@fedarko
Copy link
Collaborator Author

fedarko commented Aug 30, 2020

...Actually not sure this is a good idea (at least in terms of saving space in the HTML output by the python code), because if the amount of feature metadata is sparse then there'll be a lot of undefineds scattered throughout the array. Would probably be easier to just stick with storing feature metadata as Objects, and IIRC these are represented the same? way as arrays internally in JS so it probably wouldn't make much of a difference for performance.

@fedarko fedarko closed this as completed Aug 30, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant