-
Notifications
You must be signed in to change notification settings - Fork 31
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Emperor isn't perfectly aligned in empire plots #356
Comments
Realized that the Empire plots created by McHelper don't have this problem -- turns out my system's Emperor version was just old; updating it solved this problem. Sorry for the false alarm! |
Bizarre! Ok, I think I figured out the reason for it. It looks like toggling the bookmarks toolbar (ctrl-shift-B for me) causes this problem, at least for Chromium: not having the bookmarks bar shown makes things look wrong, while having the bookmarks bar shown makes things look normal. It seems to be a persistent thing, since refreshing the page while in the "no bookmarks bar" state still doesn't fix the problem: It turns out the problem is that, in some cases, a vertical scrollbar (for me this is a second scrollbar, next to the one Emperor sometimes creates within its side panel) can appear on the right side of the screen -- and this scrollbar seems to be what pushes over Emperor into Empress' territory. Trying to replicate this condition is kind of tricky, but it looks like 1) the bookmarks bar going away 2) while Chromium is maximized 3) and when the view.qiime2.org header is shown does it consistently for me. Ended up being solvable by adding So, uh... not sure why that impacted me specifically but it should be fixed now :P PR incoming soon. (For what it's worth, on my computer Firefox looked fine regardless of what I did with the bookmarks bar --) |
Also make the Emperor samples selected msg look pretty
so now they don't look gross :D
* BUG: fix #356 Also make the Emperor samples selected msg look pretty * On second thought don't bump up the z-index having the 'samples copied to clipboard' msg be "under" the border is nice, but this messes up a ton of empress' z-indices. not worth spending time un-messing-up today. * DOC: update readme empire screenshots re: #356 fix so now they don't look gross :D * DOC: update empire fancy screenshot * DOC: show body site summary in fancy screenshot * Document intuition with ignore absent tips
Not a big deal, but now the "31 / 31 visible" text is partially overlapped by the Empress visualization:
This is present in the master branch of Empress. Not sure where this came from -- probably some minor CSS that's messing with this.
The text was updated successfully, but these errors were encountered: