Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Emperor isn't perfectly aligned in empire plots #356

Closed
fedarko opened this issue Aug 27, 2020 · 5 comments · Fixed by #416
Closed

Emperor isn't perfectly aligned in empire plots #356

fedarko opened this issue Aug 27, 2020 · 5 comments · Fixed by #416

Comments

@fedarko
Copy link
Collaborator

fedarko commented Aug 27, 2020

Not a big deal, but now the "31 / 31 visible" text is partially overlapped by the Empress visualization:

image

This is present in the master branch of Empress. Not sure where this came from -- probably some minor CSS that's messing with this.

@fedarko
Copy link
Collaborator Author

fedarko commented Aug 28, 2020

Realized that the Empire plots created by McHelper don't have this problem -- turns out my system's Emperor version was just old; updating it solved this problem. Sorry for the false alarm!

@fedarko fedarko closed this as completed Aug 28, 2020
@fedarko
Copy link
Collaborator Author

fedarko commented Oct 9, 2020

It looks like this is happening again, this time with the McHelper versions of plots? Not sure if something changed recently in Empress or Emperor that messed things up. It's weird that the Emperor label seems to be cut off at the exact same point as previously (just before the / 41 visible).

funk

@fedarko fedarko reopened this Oct 9, 2020
@ElDeveloper
Copy link
Member

FWIW I am not seeing this issue in Safari or Chrome:

Safari

Screen Shot 2020-10-09 at 8 41 31 AM

Chrome

Screen Shot 2020-10-09 at 8 42 04 AM

@kwcantrell
Copy link
Collaborator

I dont seem to be getting this issue on firefox as well
Screenshot from 2020-10-09 08-48-10

@fedarko
Copy link
Collaborator Author

fedarko commented Oct 9, 2020

Bizarre! Ok, I think I figured out the reason for it. It looks like toggling the bookmarks toolbar (ctrl-shift-B for me) causes this problem, at least for Chromium: not having the bookmarks bar shown makes things look wrong, while having the bookmarks bar shown makes things look normal. It seems to be a persistent thing, since refreshing the page while in the "no bookmarks bar" state still doesn't fix the problem:

whatthe

It turns out the problem is that, in some cases, a vertical scrollbar (for me this is a second scrollbar, next to the one Emperor sometimes creates within its side panel) can appear on the right side of the screen -- and this scrollbar seems to be what pushes over Emperor into Empress' territory. Trying to replicate this condition is kind of tricky, but it looks like 1) the bookmarks bar going away 2) while Chromium is maximized 3) and when the view.qiime2.org header is shown does it consistently for me.

Ended up being solvable by adding overflow: hidden; to the #emperor-in-empire div, see below.

fix

So, uh... not sure why that impacted me specifically but it should be fixed now :P PR incoming soon.

(For what it's worth, on my computer Firefox looked fine regardless of what I did with the bookmarks bar --)

ff

fedarko added a commit to fedarko/empress that referenced this issue Oct 9, 2020
Also make the Emperor samples selected msg look pretty
fedarko added a commit to fedarko/empress that referenced this issue Oct 9, 2020
ElDeveloper pushed a commit that referenced this issue Oct 9, 2020
* BUG: fix #356

Also make the Emperor samples selected msg look pretty

* On second thought don't bump up the z-index

having the 'samples copied to clipboard' msg be "under" the border
is nice, but this messes up a ton of empress' z-indices. not worth
spending time un-messing-up today.

* DOC: update readme empire screenshots re: #356 fix

so now they don't look gross :D

* DOC: update empire fancy screenshot

* DOC: show body site summary in fancy screenshot

* Document intuition with ignore absent tips
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants