Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

It looks like GH actions jobs aren't getting triggered when we merge stuff into master #467

Closed
fedarko opened this issue Dec 16, 2020 · 0 comments · Fixed by #468
Closed

It looks like GH actions jobs aren't getting triggered when we merge stuff into master #467

fedarko opened this issue Dec 16, 2020 · 0 comments · Fixed by #468
Labels
logistics

Comments

@fedarko
Copy link
Collaborator

fedarko commented Dec 16, 2020

See https://github.com/biocore/empress -- although the CLI PR had a (successful) job triggered, it didn't get rerun when it was merged in to master. This means that the CI badge in the README still shows up as no status.

I think we can fix this by adding push to the YML file (alongside pull_request) as one of the actions that triggers a build.
fedarko added a commit to fedarko/empress that referenced this issue Dec 16, 2020
@fedarko
BLD: attempt to fix biocore#467
17a6ca8
@fedarko fedarko mentioned this issue Dec 16, 2020
Merged
kwcantrell pushed a commit that referenced this issue Dec 16, 2020
@fedarko
Rerun GitHub Actions on push events to master; update dev documentati…
a1acaff 
…on to mention a weird thing with JS tests (#468)

* DEV: add a note about js test HTML elements

* BLD: attempt to fix #467

* DEV: mention #435 in contributing
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
logistics
Projects
None yet
Milestone
No milestone
1 participant
@fedarko