fix #217 and add shifting to the tree #228
Conversation
|
Thanks @antgonza! Looks like there's conflicts, can you resolve those? Also, @kwcantrell if this looks good to you can you go ahead and merge this PR? |
|
@antgonza, there's conflicts again due to a merged PR. Can you re-solve conflicts? |
|
@antgonza, let's wait for @kwcantrell to submit his review and then this should be good to merge and solve conflicts. |
There was a problem hiding this comment.
@antgonza thanks, this looks good.I just have a couple minor comments.
|
|
||
| def shifting(bitlist, size=51): | ||
| """Takes a list of 0-1s, splits in size and converts it to a list of int | ||
|
|
There was a problem hiding this comment.
It might be helpful to add a simple example in the documentation.
For example, if bitlist = [1, 0, 0, 0, 0, 1] and size = 3 then [4, 1] is returned.
empress/support_files/js/bp-tree.js
Outdated
| @@ -8,11 +8,44 @@ define(["ByteArray"], function (ByteArray) { | |||
| * @param {Uint8Array} b The array that represents the tree structure | |||
There was a problem hiding this comment.
| * @param {Uint8Array} b The array that represents the tree structure | |
| * @param {Array} b The array that represents the tree structure |
empress/support_files/js/bp-tree.js
Outdated
|
|
||
| b = decoded_b; | ||
| } | ||
|
|
||
| /** | ||
| * @type {Uint8Array} |
There was a problem hiding this comment.
| * @type {Uint8Array} | |
| * @type {Array} |
|
Thanks @antgonza @kwcantrell! |
No description provided.