Support ignoring branch lengths during layout; update tree properties panel UI; some minor clade collapsing changes #363
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closes biocore#271. pretty sure clade collapsing breaks here slightly -- gotta fix
There was stuff about how DEFAULT_COLOR nodes would get ignored, and now that should be fixed (?)
also add a note about root length in unrooted layout (?)
|
The following artifacts were built for this PR: empire-biplot.qzv, empire.qzv, empress-tree.qzv |
ElDeveloper
requested changes
Sep 1, 2020
ElDeveloper
approved these changes
Sep 1, 2020
kwcantrell
reviewed
Sep 2, 2020
There was a problem hiding this comment.
Thanks @fedarko this looks nice! I just have one minor comment.
|
Thanks both! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #271. Also wound up closing #321 (ran into it along the way).
The main challenge here was making sure that updating the "ignore lengths?" setting didn't mess with the tree state. This mostly wasn't a problem, but I had to mess around some with how clade collapsing works (since as far as I can tell the previous clade collapsing stuff assumed that clades computed for a given layout could be cached; but here the same layout can have multiple ways of collapsing since the node coordinates vary based on the ignore lengths setting). I believe this works as it should now, but I'm not very familiar with this part of this code.
Other thing we should discuss -- the UI says that "the root node's length is always ignored", but it looks like the unrooted layout uses the root node's length at one point. Since we don't require that the root node has a valid or even specified length, we should discuss this to see what to do.
Thanks!