Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable browser autocomplete in node search menu #450

Merged
merged 1 commit into from
Nov 24, 2020

Conversation

fedarko
Copy link
Collaborator

@fedarko fedarko commented Nov 17, 2020

Really tiny change -- just closes #445.

@kwcantrell
Copy link
Collaborator

Thanks @fedarko! I don't chrome so I did know this was a thing. One quick comment, do you think we should add that to the empress-input css? That way this wont be an issue if we add more input boxes.

@fedarko
Copy link
Collaborator Author

fedarko commented Nov 18, 2020

That's a good point -- looked it up and I don't think there's a way to disable the autocomplete stuff with CSS (https://stackoverflow.com/a/2186406/10730311), since the autocomplete property is defined in the HTML. I think the node search bar is the only text input that is used in Empress, so we should be safe for now, but maybe we could try using something like this solution in the future if we end up having many text inputs?

@ElDeveloper ElDeveloper added this to the Pre-Refactor milestone Nov 24, 2020
@kwcantrell
Copy link
Collaborator

Okay, sounds good. Thanks @fedarko

@kwcantrell kwcantrell merged commit ae42a08 into biocore:master Nov 24, 2020
@fedarko
Copy link
Collaborator Author

fedarko commented Nov 24, 2020

Thanks @kwcantrell! 🚗

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Set autocomplete="off" on the search bar
3 participants