DOC: Remove Emperor installation note, and also bump the version number in setup.py to 1.0.1-dev #455
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This note was there to caution readers that the "pip uninstall --yes emperor" line would only temporarily uninstall Emperor, since Emperor would immediately get reinstalled when installing Empress afterwards. Now that the Emperor uninstallation line isn't present in the README instructions any more, we should just remove this note.
fedarko
changed the title
ElDeveloper
approved these changes
Nov 25, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This note was there to caution readers that the
pip uninstall --yes emperorline would only temporarily uninstallEmperor, since Emperor would immediately get reinstalled when
installing Empress afterwards.
Now that the Emperor uninstallation line isn't present in the
README instructions any more, we should just remove this note.
(Sorry for not catching this in review, I just realized it ._.)
edit: I also bumped up the version number in setup.py to
1.0.1-devnow that i think about it