Placements #34
Merged
Placements #34
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
antgonza
reviewed
Jan 21, 2022
| --output PATH Where to write the resulting newick | ||
| [required] | ||
|
|
||
| --method [fully-resolved|multifurcating] |
There was a problem hiding this comment.
I'm wondering if it somewhere in the documentation the difference between the options in this parameter should be explained. To be honest, I don't know the difference.
There was a problem hiding this comment.
actually, there is a description on line 22, is that good enough?
|
Thank you for adding the new documentation and notes; I think is ready to be merge - however, I don't have merge permissions in this repo ... |
|
Thanks!! |
|
Before release, I need to add in the requested changes on fragments with multiple placements -- more later today. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add support for handling jplace fragments
@kwcantrell, any concerns?
@antgonza, in our test data which used a 10k backbone with 1M placements, this took about 100 seconds total. Any chance you could pull down and see how this behaves with placement data from Qiita?