Cheek Samples #334
Open
Cheek Samples #334
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| "Mouth", "Nares", "Nasal mucus", "Right hand", | ||
| "Left hand", "Forehead", "Torso", "Right leg", | ||
| "Left leg", "Vaginal mucus", "Tears", "Ear wax", | ||
| "Hair", "Fur"] |
There was a problem hiding this comment.
No request for changes here, just a question: how are these entries ordered?
| $("#sample_site_last_washed_date").val(""); | ||
| $("#sample_site_last_washed_time").val(""); | ||
| $("#sample_site_last_washed_product").val("").change(); | ||
| } |
There was a problem hiding this comment.
I'm a little surprised that sample_site_last_washed_date_normalized isn't also blanked out at the same time, for the potential case where the user initially sets something as a cheek sample but then changes it. Or is that case handled at submission by the monthDayYearCheekWash validation?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is intended to address the needs surrounding collecting skin samples from cheeks:
It adds Cheek as a valid sample site to the user interface.
It adds the necessary UI components to support barcode metadata, which is explained conceptually in the corresponding microsetta-private-api PR at Cheek Samples #334
One note - integration tests will fail until the corresponding microsetta-private-api is merged into master. Unless there's a reason to do otherwise, I'd like to proceed with static code review, then revisit any necessary tweaks to the integration tests via supplemental code review if needed.