Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

open resource specific status page does not work with 'open in new tab' #87

Open
FynnBe opened this issue May 7, 2024 · 2 comments
Open

Comments

@FynnBe
Copy link
Member

FynnBe commented May 7, 2024

when clicking on a resource in the overview page (https://bioimageio-uploader.netlify.app/#/status)
the resource specific status page opens (should be the version specific status page, also):
https://bioimageio-uploader.netlify.app/#/status/committed-turkey

when opnening the same link with 'open in new tab', the /# is missing and the page cannot be found:
https://bioimageio-uploader.netlify.app/status/committed-turkey

@jmetz
Copy link
Collaborator

jmetz commented May 8, 2024

Am confused by 1) - it seems to me that going to the resource page is what would be wanted here?

For 2) perhaps prefixing all hrefs with # in the as could fix that, but I'm not 100% sure about that as it'll depend on what the router does. At the moment it intercepts a clicks to function correctly, hence the issue you're describing. "Proper" routes like https://bioimageio-uploader.netlify.app/status/committed-turkey can't work as it's a single-page-application.

jmetz added a commit that referenced this issue May 8, 2024
@jmetz
Copy link
Collaborator

jmetz commented May 8, 2024

Can confirm that the fix for 1) works - see da5f94e

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants