Improve change log #184
Merged
Improve change log #184
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
documentation
FynnBe
approved these changes
Jul 15, 2021
| - Only allow `license` identifier from the [SPDX license list](https://spdx.org/licenses/). | ||
| - Breaking changes | ||
| - The RDF file name in a package should be `rdf.yaml` for all the RDF (not `model.yaml`); | ||
| - Change `authors` and `packaged_by` fields from List[str] to List[Author] with Author consisting of a dictionary `{name: '<Full name>', affiliation: '<Affiliation>', orcid: 'optional orcid id'}`; |
There was a problem hiding this comment.
the general RDF still allows List[str]...
There was a problem hiding this comment.
.. but we can focus on the model RDF here, doesn't hurt (I'm already happy with hits ;-))
There was a problem hiding this comment.
It's a bit too complicated to clearly describe the distinction between general RDF and model RDF here, so I will leave it like this.
constantinpape
approved these changes
Jul 15, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I try to separate changes that tends to break things from other changes.
@FynnBe @constantinpape Could you also take a look and see if I missed any change in the change log?