Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix pyright checking #628

Merged
merged 4 commits into from
Sep 2, 2024
Merged

Fix pyright checking #628

merged 4 commits into from
Sep 2, 2024

Conversation

Tomaz-Vieira
Copy link
Contributor

Pyright was failing depending on the python version being used; It seems the type hints available change depending on the python version, either because the hints are gated behind version checks or because the dependencies change versions to stay compatible with the python version.

This patch squelches some warnings and tells pyright to use the version of the current interpreter instead of always using 3.8 from pyproject.toml

@github-actions github-actions bot added bug Something isn't working ci Continuous Integration github_actions Pull requests that update Github_actions code labels Sep 2, 2024
@Tomaz-Vieira Tomaz-Vieira requested a review from FynnBe September 2, 2024 09:24
@FynnBe FynnBe merged commit 37c3101 into main Sep 2, 2024
16 of 17 checks passed
@FynnBe FynnBe deleted the fix_pyright_checking branch September 2, 2024 13:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working ci Continuous Integration github_actions Pull requests that update Github_actions code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants