bug/Cast QueryInterface to QueryDimInterface #646
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Enet4
requested changes
May 29, 2023
dicoogle/src/main/java/pt/ua/dicoogle/plugins/PluginController.java
Outdated
Show resolved
Hide resolved
dicoogle/src/main/java/pt/ua/dicoogle/plugins/PluginController.java
Outdated
Show resolved
Hide resolved
|
It's seems ok for me. |
Co-authored-by: Eduardo Pinho <[email protected]>
Enet4
force-pushed
the
bug/dim_query_interface
branch
from
6f3774a to
59c4f17
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR ensures that the
getTaskForQueryDimmethod explicitly casts itsqueryEnginevar into aQueryDimInterfaceinstance, instead ofQueryInterface. The lack of casting toQueryDimInterfacewas causing issues with query providers, namely when trying to use DIM query methods.