MDS: Catch MemoryError in MDS optimization #2008
Merged
+29
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
janezd
force-pushed
the
mds-memory-error
branch
from
5ebb251 to
0ac442f
Compare
Codecov Report@@ Coverage Diff @@
## master #2008 +/- ##
==========================================
- Coverage 89.54% 89.52% -0.03%
==========================================
Files 91 91
Lines 9213 9213
==========================================
- Hits 8250 8248 -2
- Misses 963 965 +2Continue to review full report at Codecov.
|
janezd
force-pushed
the
mds-memory-error
branch
from
0ac442f to
c97ef0e
Compare
|
I am not sure what seems to be the problem with coverage, as both of the changed files are not included in coverage report. Merging anyway. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
Exceptions in MDS optimization were not caught.
Description of changes
Now they are.
Includes