CI: Raise required oldest sicpy to 1.9 #6192
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
Tests on oldest fail after #6174, "Feature Statistics: Use deferred commit + minor warning fix due to the "minor warning fix" part. In scipy 1.9,
scipy.stats.mode
introduced argumentkeepdims
and warns if it's not set. In Scipy 1.8 this argument did not exist.We overlooked this because we got so used to some test configurations failing that we don't even check. Me very included.
Description of changes
We could
keepdims
argument and live with warning, but this would hunt us some day,I see no reason against the latter. Does anybody?