[ENH] Paint Data: Slight optimization

Orange/widgets/data/owpaintdata.py

@@ -1,4 +1,4 @@
-
+from __future__ import annotations
 import os
 import unicodedata
 import itertools
@@ -90,6 +90,7 @@
 Magnet = namedtuple("Magnet", ["pos", "radius", "density"])
 SelectRegion = namedtuple("SelectRegion", ["region"])
 DeleteSelection = namedtuple("DeleteSelection", [])
+DeleteAll = namedtuple("DeleteAll", [])
 MoveSelection = namedtuple("MoveSelection", ["delta"])
 
 
@@ -112,7 +113,7 @@
 def append(command, data):
     np.clip(command.points[:, :2], 0, 1, out=command.points[:, :2])
     return (np.vstack([data, command.points]),
-            DeleteIndices(slice(len(data),
+            DeleteIndices(range(len(data),
                                 len(data) + len(command.points))))
 
 
@@ -125,7 +126,7 @@
 
 @transform.register(DeleteIndices)
 def delete(command, data, ):
-    if isinstance(command.indices, slice):
+    if isinstance(command.indices, range):
         condition = indices_to_mask(command.indices, len(data))
     else:
         indices = np.asarray(command.indices)
@@ -139,7 +140,11 @@
 
 @transform.register(Move)
 def move(command, data):
-    data[command.indices] += command.delta
+    if isinstance(command.indices, tuple):
+        idx = np.ix_(*command.indices)
+    else:
+        idx = command.indices
+    data[idx] += command.delta
     return data, Move(command.indices, -command.delta)
 
 
@@ -565,7 +570,7 @@
 
     def activate(self):
         self.editingStarted.emit()
-        self.issueCommand.emit(DeleteIndices(slice(None, None, None)))
+        self.issueCommand.emit(DeleteAll())
         self.editingFinished.emit()
 
 
@@ -631,7 +636,7 @@
         if len(ind1) != len(ind2):
             return False
         return all(indices_eq(i1, i2) for i1, i2 in zip(ind1, ind2))
-    elif isinstance(ind1, slice) and isinstance(ind2, slice):
+    elif isinstance(ind1, range) and isinstance(ind2, range):
         return ind1 == ind2
     elif ind1 is ... and ind2 is ...:
         return True
@@ -656,11 +661,10 @@
         if indices_eq(f.indices, g.indices):
             return Move(f.indices, f.delta + g.delta)
         else:
-            # TODO: union of indices, ...
             return composit
-#     elif isinstance(f, DeleteIndices) and isinstance(g, DeleteIndices):
-#         indices = np.array(g.indices)
-#         return DeleteIndices(indices)
+    elif isinstance(f, DeleteIndices) and isinstance(g, DeleteIndices):
+        indices = np.fromiter(itertools.chain(g.indices, f.indices), int)
+        return DeleteIndices(indices)
     else:
         return composit
 
@@ -1158,7 +1162,7 @@
         self.undo_stack.endMacro()
 
     def execute(self, command):
-        assert isinstance(command, (Append, DeleteIndices, Insert, Move)), \
+        assert isinstance(command, (Append, DeleteIndices, DeleteAll, Insert, Move)), \
             "Non normalized command"
         if isinstance(command, (DeleteIndices, Insert)):
             self._selected_indices = None
@@ -1197,12 +1201,17 @@
                 self.undo_stack.push(
                     UndoCommand(DeleteIndices(indices), self, text="Delete")
                 )
+        elif isinstance(cmd, DeleteAll):
+            indices = range(0, len(self.__buffer))
+            self.undo_stack.push(
+                UndoCommand(DeleteIndices(indices), self, text="Clear All")
+            )
         elif isinstance(cmd, MoveSelection):
             indices = self._selected_indices
             if indices is not None and indices.size:
                 self.undo_stack.push(
                     UndoCommand(
-                        Move((self._selected_indices, slice(0, 2)),
+                        Move((self._selected_indices, range(0, 2)),
                              np.array([cmd.delta.x(), cmd.delta.y()])),
                         self, text="Move")
                 )
@@ -1222,12 +1231,12 @@
             point = np.array([cmd.pos.x(), cmd.pos.y()])
             delta = - apply_jitter(self.__buffer[:, :2], point,
                                    self.density / 100.0, 0, cmd.rstate)
-            self._add_command(Move((..., slice(0, 2)), delta))
+            self._add_command(Move((range(0, len(self.__buffer)), range(0, 2)), delta))
         elif isinstance(cmd, Magnet):
             point = np.array([cmd.pos.x(), cmd.pos.y()])
             delta = - apply_attractor(self.__buffer[:, :2], point,
                                       self.density / 100.0, 0)
-            self._add_command(Move((..., slice(0, 2)), delta))
+            self._add_command(Move((range(0, len(self.__buffer)), range(0, 2)), delta))
         else:
             assert False, "unreachable"
 
@@ -1246,16 +1255,17 @@
             y = self.__buffer[:, 1].copy()
         else:
             y = np.zeros(self.__buffer.shape[0])
-
-        colors = self.colors[self.__buffer[:, 2]]
-        pens = [pen(c) for c in colors]
-        brushes = [QBrush(c) for c in colors]
-
+        color_table, colors_index = prepare_color_table_and_index(
+            self.colors, self.__buffer[:, 2]
+        )
+        pen_table = np.array([pen(c) for c in color_table], dtype=object)
+        brush_table = np.array([QBrush(c) for c in color_table], dtype=object)
+        pens = pen_table[colors_index]
+        brushes = brush_table[colors_index]
         self._scatter_item = pg.ScatterPlotItem(
-            x, y, symbol="+", brush=brushes, pen=pens
+            x, y, symbol="+", brush=brushes, pen=pens, size=self.symbol_size
         )
         self.plot.addItem(self._scatter_item)
-        self.set_symbol_size()
 
     def _attr_name_changed(self):
         self.plot.getAxis("bottom").setLabel(self.attr1)
@@ -1322,5 +1332,17 @@
         self.report_plot()
 
 
+def prepare_color_table_and_index(
+        palette: colorpalettes.IndexedPalette, data: np.ndarray[float]
+) -> tuple[np.ndarray[object], np.ndarray[np.intp]]:
+    # to index array and map nan to -1
+    index = np.full(data.shape, -1, np.intp)
+    mask = np.isnan(data)
+    np.copyto(index, data, where=~mask, casting="unsafe")
+    color_table = np.array([c for c in palette] + [palette[np.nan]], dtype=object)
+    return color_table, index
+
+
+
 if __name__ == "__main__":  # pragma: no cover
     WidgetPreview(OWPaintData).run()

i18n/si/msgs.jaml

@@ -6750,6 +6750,7 @@ widgets/data/owpaintdata.py:
     SelectRegion: false
     region: false
     DeleteSelection: false
+    DeleteAll: false
     MoveSelection: false
     class `PaintViewBox`:
         def `__init__`:
@@ -6845,6 +6846,7 @@ widgets/data/owpaintdata.py:
         def `_add_command`:
             Name: Ime
             Delete: Brisanje
+            Clear All: Pobriši vse
             Move: Premik
             unreachable: false
         def `_replot`:
@@ -6864,6 +6866,8 @@ widgets/data/owpaintdata.py:
             Axis y: Os y
             Number of points: Število točk
             Painted data: Narisani podatki
+    def `prepare_color_table_and_index`:
+        unsafe: false
     __main__: false
 widgets/data/owpivot.py:
     class `Pivot`: