Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updating tox version #479

Merged
merged 1 commit into from
Mar 1, 2024
Merged

Updating tox version #479

merged 1 commit into from
Mar 1, 2024

Conversation

hrshdhgd
Copy link
Collaborator

@hrshdhgd hrshdhgd commented Feb 29, 2024

tox on kgx is still using v3.x. Version 4.x is out and I get

Because kgx (2.2.5) depends on tox (>=3.0,<4.0)
 and no versions of kgx match >2.2.5,<3.0.0, kgx (>=2.2.5,<3.0.0) requires tox (>=3.0,<4.0).
So, because kg-microbe depends on both kgx (^2.2.5) and tox (>=4.13.0,<5.0.0), version solving failed.

when I try to update tox.

@hrshdhgd hrshdhgd requested review from sierra-moxon and glass-ships and removed request for glass-ships February 29, 2024 19:27
Copy link
Collaborator

@glass-ships glass-ships left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice, thanks for this!

@caufieldjh
Copy link
Collaborator

Seconding that - good catch.

@sierra-moxon sierra-moxon merged commit 47efd9f into master Mar 1, 2024
2 checks passed
@hrshdhgd hrshdhgd deleted the ease-tox-version branch March 1, 2024 17:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants