Reduce WiFi memory consumption #295
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
laszloh
force-pushed
the
feature/wifi-memory-reduction
branch
2 times, most recently
from
c247174 to
7d6c9f6
Compare
Load hostname on request from NVS and only use it on the stack. Minor fixes in the FSM handler functions
By using a linked list we do not need to allocate a single consistent memory block to save the wifi settings.
Fully rework the WiFiSettings struct to a C++ class. Add function to validate an entry and serialize & deserialize the data directly to the nvs. Integrate the new class into the Wlan.cpp and Web.cpp. Add comments to new functions
laszloh
force-pushed
the
feature/wifi-memory-reduction
branch
from
7d6c9f6 to
f174460
Compare
To reduce memory use the NVS entry directly.
Remove synthetic constrain of 10 Network entries since we do not load them into the memory any more.
Add ArduinoJson converters for IPAddress class.
Mark optional support functions with [[maybe_unused]] to supress warnings.
laszloh
force-pushed
the
feature/wifi-memory-reduction
branch
from
f174460 to
2c47f25
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR removes the WiFi settings from the RAM entirely. To improve the performance, the NVS storage is modified:
One WiFiSettings entry is serialized the following was:
[str:ssid] + [str:password] + [binary:static IP]Strings use:
[u8:len] + [len*u8:string] + [u8:'\0']Static IP use:
[u8:bool] + <u8 * 20:static IP block>This allows to NVS iteration over all entries without the need to load all entries into RAM. Old WiFi settings will be migrated to the new NVS storage structure.
For discussions see: https://forum.espuino.de/t/pr-diskussion-wifi-settings-ram-reduktion/2763