Make led, rotary & button settings configurable at runtime #358
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
biologist79
reviewed
Jan 5, 2025
html/locales/de.json
Outdated
| @@ -176,13 +225,21 @@ | |||
| "172": "Nächster Titel", | |||
| "173": "Erster Titel", | |||
| "174": "Letzter Titel", | |||
| "175": "Initialie Lautstärke", | |||
biologist79
reviewed
Jan 5, 2025
html/locales/en.json
Outdated
| "numcontrol": "Number of control LEDs", | ||
| "controlled": "Control-LED", | ||
| "numidledots": "Number of LEDs in idle state", | ||
| "offsetpause": "Centre pause LEDs", |
biologist79
reviewed
Jan 5, 2025
html/locales/de.json
Outdated
| "181": "Springe rückwärts (n Sekunden)", | ||
| "182": "Stop", | ||
| "183": "Neustart", | ||
| "199": "Taskauslastung anzeigen" |
There was a problem hiding this comment.
Vielleicht fügt man hinten noch "(Konsole)" hinzu.
biologist79
reviewed
Jan 5, 2025
html/locales/en.json
Outdated
| @@ -176,8 +225,14 @@ | |||
| "172": "Next track", | |||
| "173": "First track", | |||
| "174": "Last track", | |||
| "175": "Initial volume", | |||
| "176": "Louder", | |||
There was a problem hiding this comment.
Vielleicht ist "Volume up" bzw. "Volume down" passender. "Quieter" klingt irgendwie falsch, aber ich hab's tatsächlich mitunter auch so im Internet gefunden.
biologist79
reviewed
Jan 5, 2025
html/locales/fr.json
Outdated
| @@ -176,6 +225,11 @@ | |||
| "172": "Piste suivante", | |||
| "173": "Première piste", | |||
| "174": "Dernière piste", | |||
| "175": "Volume initial", | |||
| "176": "Louder", | |||
biologist79
reviewed
Jan 5, 2025
html/locales/fr.json
Outdated
| @@ -176,6 +225,11 @@ | |||
| "172": "Piste suivante", | |||
| "173": "Première piste", | |||
| "174": "Dernière piste", | |||
| "175": "Volume initial", | |||
| "176": "Louder", | |||
| "177": "Quieter", | |||
- led settings struct - notify task for changed settings with a queue
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR makes these settings configurable at runtime:
PR is fully backwards compatible. All existing #defines are used for now.