fix(cli): start logger only when needed (#634)

biomejs · Oct 30, 2023 · 263a26f · 263a26f
1 parent f58df06
commit 263a26f
Show file tree

Hide file tree

Showing 3 changed files with 12 additions and 1 deletion.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -18,6 +18,10 @@ Read our [guidelines for writing a good changelog entry](https://github.com/biom
 
 ### CLI
 
+#### Bug fixes
+
+- Bootstrap the logger only when needed. Contributed by @ematipico
+
 ### Configuration
 
 ### Editors

diff --git a/crates/biome_cli/src/logging.rs b/crates/biome_cli/src/logging.rs
@@ -8,6 +8,9 @@ use tracing_subscriber::util::SubscriberInitExt;
 use tracing_subscriber::{registry, Layer};
 
 pub fn setup_cli_subscriber(level: LoggingLevel, kind: LoggingKind) {
+    if level == LoggingLevel::None {
+        return;
+    }
     let format = tracing_subscriber::fmt::layer()
         .with_level(true)
         .with_target(false)
@@ -37,7 +40,7 @@ pub fn setup_cli_subscriber(level: LoggingLevel, kind: LoggingKind) {
     };
 }
 
-#[derive(Debug, Default, Clone)]
+#[derive(Debug, Default, Clone, Ord, PartialOrd, Eq, PartialEq)]
 pub enum LoggingLevel {
     /// No logs should be shown
     #[default]

diff --git a/website/src/content/docs/internals/changelog.mdx b/website/src/content/docs/internals/changelog.mdx
@@ -24,6 +24,10 @@ Read our [guidelines for writing a good changelog entry](https://github.com/biom
 
 ### CLI
 
+#### Bug fixes
+
+- Bootstrap the logger only when needed. Contributed by @ematipico
+
 ### Configuration
 
 ### Editors