changelog

biomejs · Mar 4, 2024 · 5e3fe48 · 5e3fe48
1 parent caa5e8d
commit 5e3fe48
Show file tree

Hide file tree

Showing 5 changed files with 7 additions and 4 deletions.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -149,6 +149,7 @@ our [guidelines for writing a good changelog entry](https://github.com/biomejs/b
 
   ```
   Contributed by @ematipico
+- Fix [#1774](https://github.com/biomejs/biome/issues/1774) by taking into account the option `--no-errors-on-unmatched` when running the CLI using `--changed`. Contributed by @antogyn
 
 #### Enhancements
 

diff --git a/crates/biome_cli/src/changed.rs b/crates/biome_cli/src/changed.rs
@@ -1,4 +1,4 @@
-use crate::{cli_options::CliOptions, CliDiagnostic};
+use crate::CliDiagnostic;
 use biome_fs::FileSystem;
 use biome_service::{DynRef, PartialConfiguration};
 use std::ffi::OsString;

diff --git a/crates/biome_cli/tests/commands/lint.rs b/crates/biome_cli/tests/commands/lint.rs
@@ -2683,7 +2683,6 @@ fn should_not_process_ignored_file_even_if_its_changed() {
     ));
 }
 
-
 #[test]
 fn should_not_error_for_no_changed_files_with_no_errors_on_unmatched() {
     let mut console = BufferConsole::default();
@@ -2707,7 +2706,7 @@ fn should_not_error_for_no_changed_files_with_no_errors_on_unmatched() {
                 file_path.as_os_str().to_str().unwrap(),
                 file_path2.as_os_str().to_str().unwrap(),
             ]
-                .as_slice(),
+            .as_slice(),
         ),
     );
 

diff --git a/crates/biome_fs/src/fs/memory.rs b/crates/biome_fs/src/fs/memory.rs
@@ -37,7 +37,9 @@ impl Default for MemoryFileSystem {
             files: Default::default(),
             errors: Default::default(),
             allow_write: true,
-            on_get_changed_files: Some(Arc::new(AssertUnwindSafe(Mutex::new(Some(Box::new(|| vec![])))))),
+            on_get_changed_files: Some(Arc::new(AssertUnwindSafe(Mutex::new(Some(Box::new(
+                || vec![],
+            )))))),
         }
     }
 }

diff --git a/website/src/content/docs/internals/changelog.md b/website/src/content/docs/internals/changelog.md
@@ -155,6 +155,7 @@ our [guidelines for writing a good changelog entry](https://github.com/biomejs/b
 
   ```
   Contributed by @ematipico
+- Fix [#1774](https://github.com/biomejs/biome/issues/1774) by taking into account the option `--no-errors-on-unmatched` when running the CLI using `--changed`. Contributed by @antogyn
 
 #### Enhancements
-Original file line number
+Diff line change
@@ Expand Up @@
       ```
       Contributed by @ematipico
+    - Fix [#1774](https://github.com/biomejs/biome/issues/1774) by taking into account the option `--no-errors-on-unmatched` when running the CLI using `--changed`. Contributed by @antogyn
     #### Enhancements
@@ Expand Down @@