fix(js_parser): handle edge cases for arrow expression in tenary

[kalleep]

Summary

When looking at what caused the issues describe in #1077 I first noticed that the consequent block was parsed as a arrow expression because when we try to parse an arrow function we also check for typescript return parameter.

E.g for a ? (b) : <p>{() => null}</p>; everything after : and up until => was parsed as the return parameter resulting in this being true.

My first try to fix this was to return an error when ambiguity.is_disallowed() was true and if the parsed typescript return parameter was bogus.

While this worked for this perticular case I started to play around with different tenary expressions that could generate the same result but with valid typescript syntax and found:

a ? (b) : a => {};

This expression failed both when parsing typescript and javascript but with different errors and checking for bogus typescript return type was not fixing this case.

So instead I created a specialized version of parse_assignment_expression_or_higher to use when parsing the consequent block of a tenary expression.

Playground link:
https://biomejs.dev/playground/?indentStyle=space&code=YQAgAD8AIAAoAGIAKQAgADoAIABhACAAPQA%2BACAAewB9ADsACgBhACAAPwAgACgAYgApACAAOgAgADwAcAA%2BAHsAKAApACAAPQA%2BACAAbgB1AGwAbAB9ADwALwBwAD4AOwA%3D

Closes: #1077

Test Plan

Added new test

[netlify]

✅ Deploy Preview for biomejs canceled.

Name	Link
🔨 Latest commit	a36d1b5
🔍 Latest deploy log	https://app.netlify.com/sites/biomejs/deploys/657242de7531130009749565

[Conaclos]

This looks good to me! Thanks for your contribution!

I just suggested renaming consequence and alternative to consequent and alternate. Are there some specific reasons you chose consequence and alternative?

[kalleep]

No just mixing up some words, will regenerate test files and change naming of the other tests as well 👍