fix(cli): remove ignore from crawling, and fix regression
#1249
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for biomejs canceled.
|
github-actions
bot
added
A-CLI
Conaclos
reviewed
Dec 18, 2023
unvalley
reviewed
Dec 18, 2023
ematipico
force-pushed
the
chore/remove-ignore
branch
from
f2b9787 to
2461939
Compare
ematipico
commented
Dec 18, 2023
website/src/pages/.editorconfig
Outdated
There was a problem hiding this comment.
I removed it because the top .editorconfig already does the same
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Closes #1247
The issue was introduced a long time ago (before the fork) and it went unnoticed by the majority of the contributors.
This caused some weird issues and strange things from my end. I hunted down the issue and created some tests to avoid regressions.
Unfortunately, now that Biome gained some usage, we can't emit errors, otherwise, it will break many CIs once we release this fix. Because of that, I decided to emit a warning instead.
Also, I decided to remove the
ignorecrate for crawling the file system. Unfortunately, it doesn't work very well for our needs, and it gets in the way of how we decide to handle symbolic links. Hence, I think we should handle nested.gitignoreusing a different strategy.I removed the feature from the changelog.
Test Plan
Added tests.
I did various tests by playing with the
files.ignore, and making sure I got the correct diagnostics for the files Biome can't handle.