fix(js_formatter): fix invalid formatting of nested multiline comments #1581
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Closes #1571
The potential cause of the incorrect formatting of nested multiline comments may stem from nesting
Align
s.Referencing the comment
biome/crates/biome_formatter/src/format_element/tag.rs
Line 19 in 1c91b03
Align(2) Indent Align(1)
toIndent Indent Align(1)
results in an invalid formatting.To address this, we can follow the approach used by
Prettier
and usetext(" ")
instead ofAlign(1, ...)
.Test Plan
Add a new test case