-
-
Notifications
You must be signed in to change notification settings - Fork 526
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(formatter): correctly handle comments at end of export/import list #1603
fix(formatter): correctly handle comments at end of export/import list #1603
Conversation
✅ Deploy Preview for biomejs ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Hi! Thanks for your contribution :) Ci is failing because some Rust files are not formatted and the website was not updated. |
CodSpeed Performance ReportMerging #1603 will not alter performanceFalling back to comparing Summary
|
Thanks @Conaclos - looks like my editor formatting is broken 😢 Have pushed up those two commits! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That's awesome!
Summary
Fixes #1589
Happy to receive feedback on the implementation, not sure if there are obvious edge-cases I'm not considering, but it passes the test suite!
Test Plan
Ive added a snapshot from the issue with import/export, and pass the prettier tests