fix(linter): correctly override linter presets #1606
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fix #1349
The issue was coming from the default value of
recommended
that resulted in adding disabled rules in the rule's filter.I solved the issue by first merging config with overrides before extracting the enabled rules.
This makes the code simpler and more robust because we reuse the config merge logic.
To reduce the potential cost of cloning the config for every file, I used
Cow
. Thus, the config is only cloned when a file has at least one override.