Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(config): don't include ignored files known to be jsonc files when ignoreUnknown is true #1614

Merged
merged 1 commit into from
Jan 20, 2024

Conversation

Conaclos
Copy link
Member

Summary

Fix #1607

Test Plan

I added a new test.

Copy link

netlify bot commented Jan 20, 2024

Deploy Preview for biomejs ready!

Name Link
🔨 Latest commit 9440d96
🔍 Latest deploy log https://app.netlify.com/sites/biomejs/deploys/65abcba23cd28b0008a9642e
😎 Deploy Preview https://deploy-preview-1614--biomejs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse
1 paths audited
Performance: 100 (🟢 up 1 from production)
Accessibility: 97 (no change from production)
Best Practices: 100 (no change from production)
SEO: 93 (no change from production)
PWA: -
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify site configuration.

@github-actions github-actions bot added A-CLI Area: CLI A-Project Area: project A-Website Area: website A-Changelog Area: changelog labels Jan 20, 2024
@Conaclos Conaclos merged commit 9b77dc0 into main Jan 20, 2024
19 of 20 checks passed
@Conaclos Conaclos deleted the conaclos/config/1607 branch January 20, 2024 13:44
ematipico pushed a commit to DaniGuardiola/biome that referenced this pull request Jan 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-Changelog Area: changelog A-CLI Area: CLI A-Project Area: project A-Website Area: website
Projects
None yet
Development

Successfully merging this pull request may close these issues.

🐛 IgnoreUnknown resulting in additional file being formatted
1 participant