Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(js_parser): Allow const in TsMethodSignatureTypeMember and TsCallSignatureTypeMember #1625

Merged
merged 3 commits into from
Jan 21, 2024
Merged

fix(js_parser): Allow const in TsMethodSignatureTypeMember and TsCallSignatureTypeMember #1625

merged 3 commits into from
Jan 21, 2024

Conversation

magic-akari
Copy link
Contributor

@magic-akari magic-akari commented Jan 21, 2024 •
edited
Loading

Summary

Test Plan

snapshots updated.

@netlify Netlify
Copy link

netlify bot commented Jan 21, 2024 •
edited
Loading

✅ Deploy Preview for biomejs canceled.

Name Link
🔨 Latest commit f5836f7
🔍 Latest deploy log https://app.netlify.com/sites/biomejs/deploys/65ad0ee414ae88000894ff2d

@github-actions github-actions bot added A-Parser Area: parser L-JavaScript Language: JavaScript and super languages labels Jan 21, 2024
@magic-akari magic-akari changed the title fix(js_parser): Allow const in TsMethodSignatureTypeMember fix(js_parser): Allow const in TsMethodSignatureTypeMember and TsCallSignatureTypeMember Jan 21, 2024
@magic-akari magic-akari marked this pull request as ready for review January 21, 2024 12:33
@codspeed-hq CodSpeed HQ
Copy link

codspeed-hq bot commented Jan 21, 2024 •
edited
Loading

CodSpeed Performance Report

Merging #1625 will degrade performances by 6.2%

Comparing magic-akari:fix/issue-1624 (f5836f7) with main (b6cf3ae)

Summary

⚡ 1 improvements
❌ 1 regressions
✅ 91 untouched benchmarks

⚠️ Please fix the performance issues or acknowledge them on CodSpeed.

Benchmarks breakdown

Benchmark main magic-akari:fix/issue-1624 Change
❌ db.json[cached] 72.8 ms 77.7 ms -6.2%
⚡ big5-added.json[cached] 2.4 ms 2.3 ms +6.05%

ematipico
ematipico approved these changes Jan 21, 2024
View reviewed changes
Copy link
Member

@ematipico ematipico left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Effective!

@ematipico ematipico merged commit f7fa774 into biomejs:main Jan 21, 2024
17 of 18 checks passed
@Conaclos Conaclos added the A-Changelog Area: changelog label Jan 21, 2024
ematipico pushed a commit to DaniGuardiola/biome that referenced this pull request Jan 24, 2024
@magic-akari @ematipico
fix(js_parser): Allow const in TsMethodSignatureTypeMember and TsCa…
c4500f7 
…llSignatureTypeMember (biomejs#1625)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ematipico ematipico ematipico approved these changes

Assignees
No one assigned
Labels
A-Changelog Area: changelog A-Parser Area: parser L-JavaScript Language: JavaScript and super languages
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

🐛 Failed to parse const modifier.
3 participants
@magic-akari @ematipico @Conaclos