feat(cli): make file in diagnostic clickable #1815
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for biomejs canceled.
|
github-actions
bot
added
A-Website
arendjr
approved these changes
Feb 14, 2024
ematipico
force-pushed
the
feat/clickable-files
branch
from
07e7e05 to
f9682a1
Compare
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Another QoL improvement. Now the files printed in a diagnostic are clickable. If biome is run from a terminal that is integrated in the IDE, the IDE will open that file in the specified row:column
Test Plan
The current tests should stay as is. I tested locally and it works like a charm: RustRover and VSCode
Unfortunately VSCode terminal isn't that good at underling the file, but if you hover it with the cursor, it get underlined.
RustRover instead underlines it regardless.
