Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(lint): rule noChildrenProp not valid under children in a new line #2214

Merged
merged 2 commits into from
Mar 26, 2024

Conversation

fireairforce
Copy link
Member

closes: #2211

Summary

Test Plan

@github-actions github-actions bot added A-Linter Area: linter L-JavaScript Language: JavaScript and super languages labels Mar 26, 2024
Copy link

netlify bot commented Mar 26, 2024

Deploy Preview for biomejs ready!

Name Link
🔨 Latest commit 101c715
🔍 Latest deploy log https://app.netlify.com/sites/biomejs/deploys/6602b1cd643ec00008d49d12
😎 Deploy Preview https://deploy-preview-2214--biomejs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse
1 paths audited
Performance: 99 (🔴 down 1 from production)
Accessibility: 97 (no change from production)
Best Practices: 100 (no change from production)
SEO: 93 (no change from production)
PWA: -
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify site configuration.

@github-actions github-actions bot added A-Website Area: website A-Changelog Area: changelog labels Mar 26, 2024
Copy link

codspeed-hq bot commented Mar 26, 2024

CodSpeed Performance Report

Merging #2214 will degrade performances by 6.62%

Comparing fireairforce:fix-2211 (101c715) with main (ad0a0b5)

Summary

⚡ 1 improvements
❌ 1 regressions
✅ 91 untouched benchmarks

⚠️ Please fix the performance issues or acknowledge them on CodSpeed.

Benchmarks breakdown

Benchmark main fireairforce:fix-2211 Change
db.json[cached] 74.9 ms 66.8 ms +12.11%
db.json[uncached] 80.1 ms 85.7 ms -6.62%

@fireairforce
Copy link
Member Author

Ci passed at my local:

image

CHANGELOG.md Outdated Show resolved Hide resolved
@Sec-ant
Copy link
Member

Sec-ant commented Mar 26, 2024

Thank you!

@Sec-ant Sec-ant merged commit fbab39f into biomejs:main Mar 26, 2024
15 of 16 checks passed
@fireairforce fireairforce deleted the fix-2211 branch March 26, 2024 11:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-Changelog Area: changelog A-Linter Area: linter A-Website Area: website L-JavaScript Language: JavaScript and super languages
Projects
None yet
Development

Successfully merging this pull request may close these issues.

💅 noChildrenProp doesn't throw warning/error when children passed as a prop is placed in a new a line
2 participants