[WIP] SolidJS Components return once

[marvin-j97]

Summary

Implement part of #2438

Source: https://github.com/solidjs-community/eslint-plugin-solid/blob/main/docs/components-return-once.md

Test Plan

There are generally three cases this lint rule needs to cover:

• ternary returns
• short-circuit returns (&&, ||)
• if-else returns (early returns)

Right now I only have implemented ternaries.

[netlify]

✅ Deploy Preview for biomejs ready!

Name	Link
🔨 Latest commit	30bef0d
🔍 Latest deploy log	https://app.netlify.com/sites/biomejs/deploys/661ac61ed613c400087078f3
😎 Deploy Preview	https://deploy-preview-2439--biomejs.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.
Lighthouse	1 paths audited Performance: 100 (🟢 up 1 from production) Accessibility: 97 (no change from production) Best Practices: 100 (no change from production) SEO: 93 (no change from production) PWA: - View the detailed breakdown and full score reports

---

To edit notification comments on pull requests, go to your Netlify site configuration.

[ematipico]

What do you need from us about this PR @marvin-j97? This PR is in stale for while

[marvin-j97]

What do you need from us about this PR @marvin-j97? This PR is in stale for while

I've been pretty busy with other projects so I haven't really been working on Biome.

What I do wonder is how to implement early returns. It probably needs control flow graph checking...?

[ematipico]

What I do wonder is how to implement early returns. It probably needs control flow graph checking...?

Actually, no. Usually you want to use the CFG (control flow graph) to detect if something isn't reached. Instead, you want to detect if you return statements in places where they should not be.

This means you just need to query return statements and query their ancestors until you find incompatible nodes such as if statements, loops, etc. If so, you trigger the rule.

[kotasudhakar]

when can we expect this to be done?

[marvin-j97]

when can we expect this to be done?

I'm not active working on Solid or Biome right now, so I would love for someone to pick this up.