-
-
Notifications
You must be signed in to change notification settings - Fork 526
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(lint): noMisplacedAssertion
should not report valid method calls
#2453
Conversation
✅ Deploy Preview for biomejs ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
noMisplacedAssertion
should not report methods for table-driven testsnoMisplacedAssertion
should not report against to valid method calls
CodSpeed Performance ReportMerging #2453 will improve performances by 18.94%Comparing Summary
Benchmarks breakdown
|
b579fc0
to
d3f1d67
Compare
…lacedAssertion/valid.js
…lacedAssertion/valid.js.snap
noMisplacedAssertion
should not report against to valid method callsnoMisplacedAssertion
should not report valid method calls
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just In time for the release!
There are other missing test
/it
methods, we could add it in another PR.
Summary
Closes #2443
This PR fixes false-positive of
noMisplacedAssertion
, it should not report valid method call of testing objects (such asdescribe
,test
,it
).Each test runner offers various testing APIs. This fix checks method calls against the test objects it addresses.
This PR also addresses Jest's test.each with template tag
https://jestjs.io/docs/api#2-testeachtablename-fn-timeout :
Test Plan
Added some snapshot for test API