Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(lint/useImportType): jsxRuntime wasn't respected in combined import statement #2483

Merged
merged 2 commits into from
Apr 16, 2024

Conversation

arendjr
Copy link
Contributor

@arendjr arendjr commented Apr 16, 2024

Summary

Fixes #2473

Test Plan

Test case added.

@github-actions github-actions bot added A-Linter Area: linter A-Website Area: website L-JavaScript Language: JavaScript and super languages A-Changelog Area: changelog labels Apr 16, 2024
Copy link

netlify bot commented Apr 16, 2024

Deploy Preview for biomejs ready!

Name Link
🔨 Latest commit dee3d55
🔍 Latest deploy log https://app.netlify.com/sites/biomejs/deploys/661e80e31e89ce0008f22534
😎 Deploy Preview https://deploy-preview-2483--biomejs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse
1 paths audited
Performance: 100 (no change from production)
Accessibility: 97 (no change from production)
Best Practices: 100 (no change from production)
SEO: 93 (no change from production)
PWA: -
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link
Member

@ematipico ematipico left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome

@arendjr arendjr merged commit 895e4a9 into biomejs:main Apr 16, 2024
15 of 16 checks passed
Copy link

codspeed-hq bot commented Apr 16, 2024

CodSpeed Performance Report

Merging #2483 will improve performances by 14.74%

Comparing arendjr:respect-jsxruntime-in-combined-import (dee3d55) with main (7156af0)

Summary

⚡ 1 improvements
✅ 92 untouched benchmarks

Benchmarks breakdown

Benchmark main arendjr:respect-jsxruntime-in-combined-import Change
eucjp.json[uncached] 5.6 ms 4.9 ms +14.74%

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-Changelog Area: changelog A-Linter Area: linter A-Website Area: website L-JavaScript Language: JavaScript and super languages
Projects
None yet
Development

Successfully merging this pull request may close these issues.

💅 useImportType splits React import into two, doesn't respect jsxRuntime:reactClassic setting
2 participants