Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(noUnusedLabels,noConfusingLabels): ignore Svelte reactive statements #2692

Merged
merged 2 commits into from
May 4, 2024

Conversation

Conaclos
Copy link
Member

@Conaclos Conaclos commented May 3, 2024

Summary

Fix #2571

We now ignore the use of labels named $ in Svelte components for the noUnusedLabels and noCOnfusingLabels rules.

Test Plan

I added tests for each rule.

@github-actions github-actions bot added A-Linter Area: linter L-JavaScript Language: JavaScript and super languages A-Changelog Area: changelog labels May 3, 2024
@Conaclos Conaclos changed the title fix(noUnusedLabels,noCOnfusingLabels): ignore Svelte reactive statements fix(noUnusedLabels,noConfusingLabels): ignore Svelte reactive statements May 3, 2024
Copy link

codspeed-hq bot commented May 3, 2024

CodSpeed Performance Report

Merging #2692 will not alter performance

Comparing conaclos/reactive-svelte-stetments/2571 (2295e57) with main (43525a3)

Summary

✅ 86 untouched benchmarks

@Conaclos Conaclos requested review from a team May 3, 2024 14:20
Copy link
Member

@ematipico ematipico left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should add a test where we check that the rule is still triggered for labels that aren't $

@Conaclos Conaclos merged commit 9c4be6b into main May 4, 2024
14 checks passed
@Conaclos Conaclos deleted the conaclos/reactive-svelte-stetments/2571 branch May 4, 2024 20:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-Changelog Area: changelog A-Linter Area: linter L-JavaScript Language: JavaScript and super languages
Projects
None yet
Development

Successfully merging this pull request may close these issues.

💅 Svelte Reactive Blocks marked as Unexpected/Unused
2 participants