Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(graphql_analyze): useDeprecatedReason #3289

Merged

Conversation

vohoanglong0107
Copy link
Contributor

Summary

First lint rule for GraphQL.
Enforce every @deprecated directives to have a reason argument.
Inspired by grafbase/graphql-lint

Test Plan

All tests should pass

@github-actions github-actions bot added the A-Diagnostic Area: diagnostocis label Jun 25, 2024
@vohoanglong0107 vohoanglong0107 force-pushed the feat-graphql-use-deperecated-reason branch 2 times, most recently from 0435493 to fc19905 Compare June 25, 2024 22:33
@vohoanglong0107 vohoanglong0107 force-pushed the feat-graphql-use-deperecated-reason branch from fc19905 to 6c83d94 Compare June 25, 2024 22:44
Copy link

codspeed-hq bot commented Jun 25, 2024

CodSpeed Performance Report

Merging #3289 will not alter performance

Comparing vohoanglong0107:feat-graphql-use-deperecated-reason (ab4ac1f) with main (519e316)

Summary

✅ 90 untouched benchmarks

@vohoanglong0107 vohoanglong0107 marked this pull request as ready for review June 26, 2024 00:15
Copy link
Contributor

@arendjr arendjr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

Maybe it deserves a CHANGELOG entry still?

@vohoanglong0107
Copy link
Contributor Author

Sorry, I'm still not used to writing changelog 😅 will update it asap

@github-actions github-actions bot added the A-Changelog Area: changelog label Jun 26, 2024
@arendjr arendjr merged commit 7935235 into biomejs:main Jun 26, 2024
12 checks passed
@vohoanglong0107 vohoanglong0107 deleted the feat-graphql-use-deperecated-reason branch June 26, 2024 10:20
rishabh3112 pushed a commit to rishabh3112/biome that referenced this pull request Jul 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-Changelog Area: changelog A-Diagnostic Area: diagnostocis
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants