Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(useNamingConvention): handle custom conventions on abstract classes #3473

Merged
merged 1 commit into from
Jul 19, 2024

Conversation

Conaclos
Copy link
Member

Summary

Fix #1725 (comment)

This PR fixes two bugs:

  • We erroneously rejected a valid configuration
  • We didn't set the abstract modifier flag for abstract classes

Test Plan

I added a non-regression test.

@github-actions github-actions bot added A-Linter Area: linter A-Parser Area: parser L-JavaScript Language: JavaScript and super languages A-Changelog Area: changelog labels Jul 19, 2024
Copy link
Contributor

Parser conformance results on

js/262

Test result main count This PR count Difference
Total 48353 48353 0
Passed 47156 47156 0
Failed 1197 1197 0
Panics 0 0 0
Coverage 97.52% 97.52% 0.00%

jsx/babel

Test result main count This PR count Difference
Total 40 40 0
Passed 37 37 0
Failed 3 3 0
Panics 0 0 0
Coverage 92.50% 92.50% 0.00%

symbols/microsoft

Test result main count This PR count Difference
Total 6556 6556 0
Passed 2203 2203 0
Failed 4353 4353 0
Panics 0 0 0
Coverage 33.60% 33.60% 0.00%

ts/babel

Test result main count This PR count Difference
Total 670 670 0
Passed 598 598 0
Failed 72 72 0
Panics 0 0 0
Coverage 89.25% 89.25% 0.00%

ts/microsoft

Test result main count This PR count Difference
Total 18290 18290 0
Passed 14018 14018 0
Failed 4272 4272 0
Panics 0 0 0
Coverage 76.64% 76.64% 0.00%

@Conaclos Conaclos force-pushed the conaclos/useNamingConvention-abstract-class branch from 1bd560a to 78b1694 Compare July 19, 2024 10:17
@Conaclos Conaclos merged commit 2ef23e7 into main Jul 19, 2024
15 checks passed
@Conaclos Conaclos deleted the conaclos/useNamingConvention-abstract-class branch July 19, 2024 10:33
Copy link

codspeed-hq bot commented Jul 19, 2024

CodSpeed Performance Report

Merging #3473 will improve performances by 6.7%

Comparing conaclos/useNamingConvention-abstract-class (78b1694) with main (ff6a9a1)

Summary

⚡ 1 improvements
✅ 103 untouched benchmarks

Benchmarks breakdown

Benchmark main conaclos/useNamingConvention-abstract-class Change
react.production.min_3378072959512366797.js[cached] 2 ms 1.9 ms +6.7%

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-Changelog Area: changelog A-Linter Area: linter A-Parser Area: parser L-JavaScript Language: JavaScript and super languages
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant