Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ci: fix check deps error #3851

Merged
merged 1 commit into from
Sep 11, 2024
Merged

ci: fix check deps error #3851

merged 1 commit into from
Sep 11, 2024

Conversation

Conaclos
Copy link
Member

Summary

Fix the CI error and some warnings.

Test Plan

CI must pass.

@github-actions github-actions bot added A-Linter Area: linter A-Formatter Area: formatter A-Tooling Area: internal tools L-JavaScript Language: JavaScript and super languages labels Sep 11, 2024
@codspeed-hq CodSpeed HQ
Copy link

codspeed-hq bot commented Sep 11, 2024

CodSpeed Performance Report

Merging #3851 will degrade performances by 6.68%

Comparing conaclos/fix-check-deps-error (7e44925) with main (7ffc53f)

Summary

❌ 1 regressions
✅ 106 untouched benchmarks

⚠️ Please fix the performance issues or acknowledge them on CodSpeed.

Benchmarks breakdown

Benchmark main conaclos/fix-check-deps-error Change
❌ router_17129688031671448157.ts[uncached] 2.4 ms 2.6 ms -6.68%

@Conaclos Conaclos merged commit 83e5cef into main Sep 11, 2024
14 of 15 checks passed
@Conaclos Conaclos deleted the conaclos/fix-check-deps-error branch September 11, 2024 14:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dyc3 dyc3 dyc3 approved these changes

Assignees
No one assigned
Labels
A-Formatter Area: formatter A-Linter Area: linter A-Tooling Area: internal tools L-JavaScript Language: JavaScript and super languages
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Conaclos @dyc3