-
-
Notifications
You must be signed in to change notification settings - Fork 523
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(intellij): Use node interpreter to run commands #416
fix(intellij): Use node interpreter to run commands #416
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you @victor-teles ! I would be nice to have a section in the CONTRIBUTING.md
that explains a bit the UI testing and how a maintainer can run them locally
editors/intellij/src/main/kotlin/com/github/biomejs/intellijbiome/widgets/BiomeWidget.kt
Outdated
Show resolved
Hide resolved
@ematipico I'll update CONTRIBUTING.md and add the new README.md |
8e78744
to
19ce301
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for quick fix! I think you can merge PR
I commented on some of the points I would like to see addressed in another follow up PR.
|
||
https://biomejs.dev plugin for JetBrains IDEs. | ||
[Biome](https://biomejs.dev/) is a powerful tool designed to enhance your development experience. This plugin integrates seamlessly with many [JetBrains IDE's](#Supported IDEs) to provide some capabilities: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is great! The updated readme is really helpful for users!
I think this should be reflected to META-INF/plugin.xml by follow up PR. (We've passed on using org.jetbrains.changelog.markdownToHTML
in the past, but maybe it's time to use)
@@ -190,6 +190,16 @@ Build and run the plugin requires: | |||
./gradlew buildPlugin | |||
``` | |||
|
|||
### UI Testing intellij plugin | |||
|
|||
Before start testing the plugin you will need to start IDE by invoking the `./gradlew runIdeForUiTests &` and wait IDE startup |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think it is better to mention pnpm install
is needed
By the way, the UI test did not work on my end with the following error. test result
IDE error
|
@nissy-dev Thank you very much for the review, I will address your points in another PR |
Summary
Fixes #404 - explanation
For windows the plugin need to use
node
interpreter to be able to runbiome lsp-proxy
andbiome format
Fix for
biome format
for #402 - explanationThe
biome format
command was running withoutcwd
, now it's set to run on projects rootTest Plan