Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: remove support for rome-ignore #4252

Merged
merged 7 commits into from
Oct 11, 2024
Merged

Conversation

ematipico
Copy link
Member

Summary

Closes #4251

This PR also includes 65fb844, which I lost due to me being an idiot during the rebases.

Test Plan

Updated existing tests.

@github-actions github-actions bot added A-CLI Area: CLI A-Core Area: core A-Project Area: project A-Linter Area: linter A-LSP Area: language server protocol L-JavaScript Language: JavaScript and super languages L-CSS Language: CSS labels Oct 11, 2024
@ematipico ematipico changed the title feat: remove support for rome.json (#4244) feat: remove support for rome-ignore Oct 11, 2024
@dyc3
Copy link
Contributor

dyc3 commented Oct 11, 2024

Rebase this on next?

@ematipico ematipico changed the base branch from main to next October 11, 2024 09:57
Copy link

codspeed-hq bot commented Oct 11, 2024

CodSpeed Performance Report

Merging #4252 will degrade performances by 7.34%

Comparing feat/remove-rome-ignore (7868cce) with next (8b3c102)

Summary

❌ 1 regressions
✅ 104 untouched benchmarks

⚠️ Please fix the performance issues or acknowledge them on CodSpeed.

Benchmarks breakdown

Benchmark next feat/remove-rome-ignore Change
db_17847247775464589309.json[cached] 12.7 ms 13.7 ms -7.34%

@github-actions github-actions bot added the A-Formatter Area: formatter label Oct 11, 2024
@ematipico ematipico merged commit ce12ff0 into next Oct 11, 2024
11 of 12 checks passed
@ematipico ematipico deleted the feat/remove-rome-ignore branch October 11, 2024 16:08
ematipico added a commit that referenced this pull request Oct 18, 2024
ematipico added a commit that referenced this pull request Oct 18, 2024
Conaclos pushed a commit that referenced this pull request Oct 19, 2024
ematipico added a commit that referenced this pull request Oct 23, 2024
ematipico added a commit that referenced this pull request Oct 31, 2024
ematipico added a commit that referenced this pull request Nov 7, 2024
ematipico added a commit that referenced this pull request Nov 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-CLI Area: CLI A-Core Area: core A-Formatter Area: formatter A-Linter Area: linter A-LSP Area: language server protocol A-Project Area: project L-CSS Language: CSS L-JavaScript Language: JavaScript and super languages
Projects
None yet
Development

Successfully merging this pull request may close these issues.

BREAKING: Remove support for suppression comments rome-ignore
2 participants