Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: useExhaustiveDependencies not recommended #4294

Merged
merged 2 commits into from
Oct 23, 2024

Conversation

ematipico
Copy link
Member

Summary

Closes #4293

Test Plan

CI should pass

@github-actions github-actions bot added A-Linter Area: linter L-JavaScript Language: JavaScript and super languages labels Oct 14, 2024
Copy link

codspeed-hq bot commented Oct 14, 2024

CodSpeed Performance Report

Merging #4294 will not alter performance

Comparing feat/do-not-recommend-rule (22d33d4) with next (98a0840)

Summary

✅ 101 untouched benchmarks

@github-actions github-actions bot added the A-Project Area: project label Oct 14, 2024

# The rule `useExhaustiveDependencies` isn't recommended anymore

The rule `useExhaustiveDependencies` is not recommended anymore. If your codebase uses `react` and relies on that rule, you have to enable it:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hopefully this will be improved before the actual release then.

@ematipico ematipico force-pushed the next branch 3 times, most recently from 29571e9 to 8cd2fef Compare October 23, 2024 08:27
@ematipico ematipico force-pushed the feat/do-not-recommend-rule branch from 64c973b to 22d33d4 Compare October 23, 2024 11:38
@ematipico ematipico merged commit 270cf3c into next Oct 23, 2024
12 checks passed
@ematipico ematipico deleted the feat/do-not-recommend-rule branch October 23, 2024 12:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-Linter Area: linter A-Project Area: project L-JavaScript Language: JavaScript and super languages
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants