-
-
Notifications
You must be signed in to change notification settings - Fork 512
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: use camino for paths #4797
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
A-CLI
Area: CLI
A-Core
Area: core
A-Project
Area: project
A-Linter
Area: linter
A-Parser
Area: parser
A-Formatter
Area: formatter
A-Tooling
Area: internal tools
A-LSP
Area: language server protocol
L-JavaScript
Language: JavaScript and super languages
L-CSS
Language: CSS
L-JSON
Language: JSON and super languages
A-Diagnostic
Area: diagnostocis
L-HTML
Language: HTML
L-Grit
Language: GritQL
labels
Dec 26, 2024
CodSpeed Performance ReportMerging #4797 will not alter performanceComparing Summary
|
Conaclos
reviewed
Dec 26, 2024
In this PR I also changed how
This simplifies the APIs |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
A-CLI
Area: CLI
A-Core
Area: core
A-Diagnostic
Area: diagnostocis
A-Formatter
Area: formatter
A-Linter
Area: linter
A-LSP
Area: language server protocol
A-Parser
Area: parser
A-Project
Area: project
A-Tooling
Area: internal tools
L-CSS
Language: CSS
L-Grit
Language: GritQL
L-HTML
Language: HTML
L-JavaScript
Language: JavaScript and super languages
L-JSON
Language: JSON and super languages
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR removes the use of
Path
andPathBuf
from the majority of the code base, mostly where it counts (Workspace, CLI and LSP), and usescamino
UTF-8 paths.I did some research and other Rust-based compilers have made this choice, and the team agreed that this should be a very safe choice.
Test Plan
Existing tests should pass