fix(js_parser): parse huge binary expressions #4856
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
A-Parser
CodSpeed Performance ReportMerging #4856 will not alter performanceComparing Summary
|
arendjr
force-pushed
the
fix-recursive-binary-expressions
branch
from
6d98e2e to
de4954f
Compare
arendjr
force-pushed
the
fix-recursive-binary-expressions
branch
from
de4954f to
e78afdd
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #4563.
We used a recursive algorithm for parsing binary expressions, which triggered a stack overflow for huge expressions.
This PR changes the algorithm to be fully imperative instead. I also had to change our generated
Debugimplementations for nodes, because after I had fixed the parser, those triggered another overflow.This PR looks huge, but it's really just the test cases.
Test Plan
Test added.