Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor(js_analyze): turn on requireAscii #4945

Merged
merged 1 commit into from
Jan 23, 2025
Merged

refactor(js_analyze): turn on requireAscii #4945

merged 1 commit into from
Jan 23, 2025

Conversation

Conaclos
Copy link
Member

Summary

Closes #1918

Test Plan

I updated the tests.

@github-actions github-actions bot added A-CLI Area: CLI A-Core Area: core A-Project Area: project A-Linter Area: linter A-Parser Area: parser A-Formatter Area: formatter A-Tooling Area: internal tools A-LSP Area: language server protocol L-JavaScript Language: JavaScript and super languages L-CSS Language: CSS L-JSON Language: JSON and super languages A-Diagnostic Area: diagnostocis A-Changelog Area: changelog L-HTML Language: HTML L-Grit Language: GritQL labels Jan 22, 2025
@Conaclos Conaclos changed the base branch from main to next January 22, 2025 21:24
@github-actions github-actions bot removed A-Core Area: core A-Project Area: project A-Parser Area: parser A-Formatter Area: formatter A-Tooling Area: internal tools A-LSP Area: language server protocol L-CSS Language: CSS A-Diagnostic Area: diagnostocis A-Changelog Area: changelog L-HTML Language: HTML L-Grit Language: GritQL labels Jan 22, 2025
@Conaclos Conaclos requested review from a team January 22, 2025 21:25
@Conaclos Conaclos changed the title Conaclos/require ascii naming conventions refactor(js_analyze): turn on requireAscii Jan 22, 2025
@Conaclos Conaclos changed the title refactor(js_analyze): turn on requireAscii refactor(js_analyze): turn on requireAscii Jan 22, 2025
@codspeed-hq CodSpeed HQ
Copy link

codspeed-hq bot commented Jan 22, 2025 •
edited
Loading

CodSpeed Performance Report

Merging #4945 will not alter performance

Comparing conaclos/require-ascii-naming-conventions (1960bfd) with next (66823f7)

Summary

✅ 95 untouched benchmarks

@ematipico ematipico merged commit 069cbb4 into next Jan 23, 2025
13 of 15 checks passed
@ematipico ematipico deleted the conaclos/require-ascii-naming-conventions branch January 23, 2025 05:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ematipico ematipico ematipico approved these changes

Assignees
No one assigned
Labels
A-CLI Area: CLI A-Linter Area: linter L-JavaScript Language: JavaScript and super languages L-JSON Language: JSON and super languages
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

📎 turn on requireAscii by default
2 participants
@Conaclos @ematipico