chore: print diagnostics using relative paths #5009
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
A-CLI
ematipico
changed the title
github-actions
bot
added
A-Tooling
CodSpeed Performance ReportMerging #5009 will not alter performanceComparing Summary
|
ematipico
force-pushed
the
chore/use-relative-paths
branch
from
a366d42 to
9dd8cfd
Compare
ematipico
force-pushed
the
chore/use-relative-paths
branch
from
e12dece to
31d7015
Compare
github-actions
bot
added
L-JavaScript
ematipico
commented
Feb 3, 2025
Comment on lines
454
to
+464
| pub enum FsErrorKind { | ||
| /// File not found | ||
| CantReadFile(String), | ||
| CantReadFile, | ||
| /// Unknown file type | ||
| UnknownFileType, | ||
| /// Dereferenced (broken) symbolic link | ||
| DereferencedSymlink(String), | ||
| DereferencedSymlink, | ||
| /// Too deeply nested symbolic link expansion | ||
| DeeplyNestedSymlinkExpansion(String), | ||
| DeeplyNestedSymlinkExpansion, | ||
| /// Invalid UTF-8 characters in path. | ||
| NonUtf8Path(PathBuf), | ||
| NonUtf8Path, |
There was a problem hiding this comment.
The String in these variants were the file path, but we already have this information in the location(resource) of the diagnostic itself. It was redundant information
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Closes #3946
Test Plan
Updated the snapshots. CI should stay green