Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor(migrate): use includes when migrating from eslint and prettier #5012

Merged
merged 1 commit into from
Feb 2, 2025
Merged

refactor(migrate): use includes when migrating from eslint and prettier #5012

merged 1 commit into from
Feb 2, 2025

Conversation

Conaclos
Copy link
Member

@Conaclos Conaclos commented Feb 1, 2025

Summary

Part of #4611

Use includes instead pf ignore/include when migrating with biome migrate eslint and biome migrate prettier

Test Plan

I updated the tests.
I plan to do some tests in real conditions before merging this PR to make sure that nothing is broken.

@github-actions github-actions bot added the A-CLI Area: CLI label Feb 1, 2025
@codspeed-hq CodSpeed HQ
Copy link

codspeed-hq bot commented Feb 1, 2025

CodSpeed Performance Report

Merging #5012 will not alter performance

Comparing conaclos/migrate-eslint-prettier-includes (f149620) with next (0681bcc)

Summary

✅ 94 untouched benchmarks

@Conaclos Conaclos merged commit 703bff0 into next Feb 2, 2025
10 of 12 checks passed
@Conaclos Conaclos deleted the conaclos/migrate-eslint-prettier-includes branch February 2, 2025 12:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ematipico ematipico ematipico approved these changes

Assignees
No one assigned
Labels
A-CLI Area: CLI
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Conaclos @ematipico